upstream/Botania
1
0 Fork 0
mirror of https://github.com/GTNewHorizons/Botania.git synced 2026-10-26 14:24:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix tps lag introduced by onSpawn methods

Browse Source 
Especially in Orespawn dimensions like unstable dimension theses methods destroys tps before

Tested in my modpack

spark profiler before : ~ 13 ms
https://spark.lucko.me/6KkG1Tq4Su

spark profiler after :  ~ 8.5 ms
https://spark.lucko.me/6m2vv9Hb1X

However, originals versions may be more appropriate in some situations where you need to find all players in a given area rather than the closest player.
This commit is contained in:
QUENTIN453 committed 2023-04-30 16:48:45 +02:00
1 parent 2f47326c7f
commit 76a23a28db
2 files changed
+10 -14
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/main/java/vazkii/botania/common/brew/potion/PotionBloodthirst.java
+5 -7
View File
@@ -34,13 +34,11 @@ public class PotionBloodthirst extends PotionMod {
@SubscribeEvent
public void onSpawn(LivingSpawnEvent.CheckSpawn event) {
if(event.getResult() != Result.ALLOW && event.entityLiving instanceof IMob) {
List<EntityPlayer> players = event.world.getEntitiesWithinAABB(EntityPlayer.class, AxisAlignedBB.getBoundingBox(event.x - RANGE, event.y - RANGE, event.z - RANGE, event.x + RANGE, event.y + RANGE, event.z + RANGE));
for(EntityPlayer player : players)
if(hasEffect(player) && !hasEffect(player, ModPotions.emptiness)) {
event.setResult(Result.ALLOW);
return;
}
if (event.getResult() != Result.ALLOW && event.entityLiving instanceof IMob) {
EntityPlayer player = event.world.getClosestPlayerToEntity(event.entityLiving, RANGE);
if (player != null && hasEffect(player) && !hasEffect(player, ModPotions.emptiness)) {
event.setResult(Result.ALLOW);
}
}
}
src/main/java/vazkii/botania/common/brew/potion/PotionEmptiness.java
+5 -7
View File
@@ -33,13 +33,11 @@ public class PotionEmptiness extends PotionMod {
@SubscribeEvent
public void onSpawn(LivingSpawnEvent.CheckSpawn event) {
if(event.getResult() != Result.ALLOW && event.entityLiving instanceof IMob) {
List<EntityPlayer> players = event.world.getEntitiesWithinAABB(EntityPlayer.class, AxisAlignedBB.getBoundingBox(event.x - RANGE, event.y - RANGE, event.z - RANGE, event.x + RANGE, event.y + RANGE, event.z + RANGE));
for(EntityPlayer player : players)
if(hasEffect(player)) {
event.setResult(Result.DENY);
return;
}
if (event.getResult() != Result.ALLOW && event.entityLiving instanceof IMob) {
EntityPlayer player = event.world.getClosestPlayerToEntity(event.entityLiving, RANGE);
if (player != null && hasEffect(player)) {
event.setResult(Result.DENY);
}
}
}